Add cgroup RSS queries #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afcollins
commented
Nov 8, 2024
| - query: sum( (node_memory_MemTotal_bytes - node_memory_MemAvailable_bytes) and on (instance) label_replace(kube_node_role{role="worker"}, "instance", "$1", "node", "(.+)") ) | ||
| metricName: memory-sum-workers | ||
| instant: true | ||
| captureStart: true |
There was a problem hiding this comment.
Adding this metric because it allows us to calculate the memory delta over the run, with start and end instant measurements. This can help us detect memory leaks over the course of a run.
afcollins
force-pushed
the
metrics-cgroup-rss
branch
2 times, most recently
from
cf973a8 to
aaccc5d
Compare
|
Rebased on latest main to remove merge commit, added commit sign-off, and corrected the minor formatting differences between the files for the same queries so the diff is cleaner. |
afcollins
commented
Nov 12, 2024
afcollins
force-pushed
the
metrics-cgroup-rss
branch
from
aaccc5d to
3361b55
Compare
|
Removed a duplicate query. It's all good now. PTAL |
afcollins
force-pushed
the
metrics-cgroup-rss
branch
from
3361b55 to
80590e1
Compare
rsevilla87
reviewed
Nov 13, 2024
afcollins
force-pushed
the
metrics-cgroup-rss
branch
from
80590e1 to
38790d3
Compare
Signed-off-by: Andrew Collins <[email protected]>
afcollins
force-pushed
the
metrics-cgroup-rss
branch
from
38790d3 to
bbffbc4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adding corresponding memory RSS queries for existing cgroup metrics.
Checklist before requesting a review