Fix golangci-lint precommit hook #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raul Sevilla <[email protected]>
Disabling revive due to false positives: ``` $ make lint Executing pre-commit for all files pre-commit run --all-files [INFO] Initializing environment for https://github.com/golangci/golangci-lint. [INFO] Installing environment for https://github.com/golangci/golangci-lint. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... golangci-lint............................................................Failed - hook id: golangci-lint - exit code: 1 WARN [config_reader] The configuration option `linters.errcheck.ignore` is deprecated, please use `linters.errcheck.exclude-functions`. crd-scale.go:32:16: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) PreRun: func(cmd *cobra.Command, args []string) { ^ crd-scale.go:35:33: unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive) Run: func(cmd *cobra.Command, args []string) { ^ node-density-cni.go:39:16: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) PreRun: func(cmd *cobra.Command, args []string) { ^ egressip.go:155:16: unused-parameter: parameter 'cmd' seems to be unused, consider removing or renaming it as _ (revive) PreRun: func(cmd *cobra.Command, args []string) { ^ node-density-cni.go:51:33: unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive) Run: func(cmd *cobra.Command, args []string) { ^ egressip.go:162:33: unused-parameter: parameter 'args' seems to be unused, consider removing or renaming it as _ (revive) Run: func(cmd *cobra.Command, args []string) { ^ ``` Signed-off-by: Raul Sevilla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
The previous hook wasn't working as expected as it was relying on this configuration https://github.com/golangci/golangci-lint/blob/master/.pre-commit-hooks.yaml#L1-L8
golangci-lint run --new-from-rev HEAD --fix, the hook's command basically fixes linting errors when the current code is different from HEAD (so no action is taken when changes are committed), this is not what we actually need, we want to report and hang on linting errors caused by a PR.Also fixing some pieces of code to meet linting.
Related Tickets & Documents