network: fix private sandbox netns #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zhang Tianyang <[email protected]>
Burning1020
force-pushed
the
optim-sandbox-life
branch
from
7f1007a to
4eb4a7c
Compare
1. Add many roll back handlers in the process of starting sandbox. 2. Move setup network to Start sandbox as it should be called near the vm startup. 3. Only monit running sandbox and dump it status in time. 4. Sandbox stop should make sure the sandbox is stopped successfully, so wait it to stop for 10s. 5. If the VM process terminated suddenly and the containerd has no idea to stop sandbox, destroy network should be done in monit thread. 6. Forcefully kill vmm process in stopping sandbox. Signed-off-by: Zhang Tianyang <[email protected]>
Burning1020
force-pushed
the
optim-sandbox-life
branch
from
4eb4a7c to
b285b07
Compare
abel-von
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize sandbox lifecycle management
to stop for 10s.
sandbox, destroy network should be done in monit thread.
Signed-off-by: Zhang Tianyang [email protected]