Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task: some bugfixs #112

Merged
merged 3 commits into from
Jan 24, 2024
Merged

task: some bugfixs #112

merged 3 commits into from
Jan 24, 2024

Conversation

Burning1020
Copy link
Member

  1. report more OCI runtime errors
  2. delete pid file of exec process
  3. implement close_io

@Burning1020 Burning1020 requested a review from a team as a code owner January 19, 2024 10:43
@Burning1020 Burning1020 changed the title Bugfix task task: some bugfixs Jan 19, 2024
@Burning1020 Burning1020 force-pushed the bugfix-task branch 5 times, most recently from 3a111f6 to 4d237e2 Compare January 24, 2024 02:10
morningtzh
morningtzh approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@morningtzh morningtzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flyflypeng
flyflypeng reviewed Jan 24, 2024
View reviewed changes
vmm/task/src/container.rs Outdated
Ok(file) => {
let mut lines = BufReader::new(file).lines();
while let Ok(Some(line)) = lines.next_line().await {
// Retrieve the last runtime error
match serde_json::from_str::<Log>(&line) {
Err(err) => return other!("{}: unable to parse log msg: {}", msg, err),
Err(e) => return Err(other!("unable to parse log msg: {}", e)),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we can search for the most recent error-level log information in the log file by moving backward from the end of the file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Burning1020 Burning1020 force-pushed the bugfix-task branch 5 times, most recently from 70dccf8 to 1a94d13 Compare January 24, 2024 04:53
@flyflypeng
Copy link
Member

LGTM

@flyflypeng flyflypeng merged commit ac2c98a into kuasar-io:main Jan 24, 2024
15 checks passed
@Burning1020 Burning1020 deleted the bugfix-task branch April 7, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyflypeng flyflypeng flyflypeng approved these changes

@morningtzh morningtzh morningtzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Burning1020 @flyflypeng @morningtzh