Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0] app icon 변경 액션 추가 #33

Merged
merged 5 commits into from
Oct 4, 2023
Merged

[2.0.0] app icon 변경 액션 추가 #33

merged 5 commits into from
Oct 4, 2023

Conversation

sunshiningsoo
Copy link
Member

@sunshiningsoo sunshiningsoo commented Sep 30, 2023 •
edited
Loading

작업

  • app icon을 변경할 수 있는 기본적인 SettingView와 기능을 작업했습니다.

구현 문제점

  • 앱 아이콘을 선택 후, alert창의 확인 버튼을 누른 이후에 모달을 dismiss되게 만들려고 Effect.run을 사용했는데 아래와 같은 오류가 나옵니다. 도움 요청합니다.. (AppIconSelectView: 57, 58라인)

이미지 리소스 파일명 관련 이슈

#22 (comment)

작동 화면

Simulator Screen Recording - iPhone 15 Pro - 2023-10-01 at 03 02 51

@sunshiningsoo sunshiningsoo requested review from x-0o0 and lgvv September 30, 2023 18:08
@sunshiningsoo sunshiningsoo self-assigned this Sep 30, 2023
x-0o0
x-0o0 reviewed Sep 30, 2023
View reviewed changes
KuringApp/KuringApp/Assets.xcassets/AppIcon.appiconset/Contents.json Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/AppIconSelectView.swift Outdated Show resolved Hide resolved
KuringApp/KuringApp/Setting/SettingView.swift Outdated Show resolved Hide resolved
@x-0o0 x-0o0 linked an issue Oct 1, 2023 that may be closed by this pull request
앱아이콘 변경 가능하게 하기 #22
Closed
x-0o0
x-0o0 approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@x-0o0 x-0o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lgvv
lgvv approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@lgvv lgvv left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와,, Dependency 부분을 정말 유려하게 사용하셔서 배울게 많은 코드인 것 같습니다!

요 부분은 따로 더 공부해봐야 겠습니다~!

@sunshiningsoo sunshiningsoo requested review from x-0o0 and lgvv October 4, 2023 14:47
lgvv
lgvv approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@lgvv lgvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모바일 Approve 색상이 쿠링 색이네요..?ㅋㅋㅋㅎㅋㅋ

@sunshiningsoo sunshiningsoo merged commit 9888341 into develop/2.0.0 Oct 4, 2023
@x-0o0 x-0o0 deleted the feature/sungsoo/settingView+appIcon branch October 4, 2023 15:39
@x-0o0 x-0o0 removed their request for review October 4, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-0o0 x-0o0 x-0o0 approved these changes

@lgvv lgvv lgvv approved these changes

Assignees

@sunshiningsoo sunshiningsoo

Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

앱아이콘 변경 가능하게 하기
3 participants
@sunshiningsoo @x-0o0 @lgvv