Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.0.0] 최근 검색어 기능 구현 #173

Merged
merged 2 commits into from
Mar 25, 2024
Merged

[2.0.0] 최근 검색어 기능 구현 #173

merged 2 commits into from
Mar 25, 2024

Conversation

lgvv
Copy link
Member

@lgvv lgvv commented Mar 25, 2024

내용

  • 최근 검색어 기능을 구현
  • devleop 브랜치에서 빌드가 안되는 이슈를 수정
    • 특정 변수명이 다르게 작성되어 있었음
  • v1에는 단일 삭제가 있었으나 v2에서는 아직 구현이 안되어 있어서 removeAll로 대체

@lgvv lgvv added 새기능/개선작업 새 기능 작업 또는 개선 작업 v2 검색 검색기능 TCA labels Mar 25, 2024
@lgvv lgvv self-assigned this Mar 25, 2024
@lgvv lgvv linked an issue Mar 25, 2024 that may be closed by this pull request
[Search] 최근 검색어 로직 #175
Closed
x-0o0
x-0o0 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@x-0o0 x-0o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package-kuring/Sources/UIKit/SearchUI/SearchView.swift Show resolved Hide resolved
@lgvv lgvv requested a review from x-0o0 March 25, 2024 16:01
x-0o0
x-0o0 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@x-0o0 x-0o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@x-0o0
Copy link
Contributor

x-0o0 commented Mar 25, 2024

/쿠링 머지

@github-actions github-actions bot added the automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. label Mar 25, 2024
@github-actions github-actions bot merged commit 68a7a8c into develop/2.0.0 Mar 25, 2024
@github-actions github-actions bot deleted the feature/lgvv/search-feature branch March 25, 2024 16:02
@github-actions GitHub Actions
Copy link

🕊️ PR #173이 머지되었습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x-0o0 x-0o0 x-0o0 approved these changes

Assignees

@lgvv lgvv

Labels
automerge auto merge 를 수동으로 미리 활성화 하는 경우 라벨을 추가해줘야 합니다. "/쿠링 머지" 실행시 자동으로 추가. TCA v2 검색 검색기능 새기능/개선작업 새 기능 작업 또는 개선 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search] 최근 검색어 로직
2 participants
@lgvv @x-0o0