Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.0] 공지사항 UI에 발생하던 이슈 수정 #155

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

lgvv
Copy link
Member

@lgvv lgvv commented Mar 17, 2024

내용

기존 List를 사용하던 구조에서

아래 구조로 변경

  • 밑줄은 Divider 활용
  • 고민: 제목이 한줄이어도 Row frame height 고정해서 보여주는건 어떨지.
    • 셀이 너무 좁아보임.
ScrollView {
    LazyVStack { 
        ForEach { ... }
        Divider()
    }
}

@lgvv lgvv added v2 공지리스트 공지디테일, 공지리스트 기능 디자인시스템 디자인 시스템 labels Mar 17, 2024
@lgvv lgvv self-assigned this Mar 17, 2024
@lgvv lgvv requested review from x-0o0 and sunshiningsoo March 17, 2024 17:35
@lgvv lgvv linked an issue Mar 17, 2024 that may be closed by this pull request
Copy link
Contributor

@x-0o0 x-0o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고민: 제목이 한줄이어도 Row frame height 고정해서 보여주는건 어떨지.
셀이 너무 좁아보임.

디자이너분들과 한번 논의해보세욥~!
그리고 공지 제목과 날짜 사이의 간격이 Figma 에서는 더 넓은걸로 보여지네욥!

@x-0o0 x-0o0 merged commit fa967dd into develop/2.0.0 Mar 19, 2024
@x-0o0 x-0o0 deleted the feature/lgvv/notice-ui branch March 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 공지리스트 공지디테일, 공지리스트 기능 디자인시스템 디자인 시스템
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0.0] NoticeRow 작업
2 participants