Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #3

Merged
merged 3 commits into from
Aug 19, 2019
Merged

Conversation

ochmanski
Copy link
Contributor

@ochmanski ochmanski commented Aug 18, 2019

Description

Hi, I've updated dependencies (mostly what matters is svelte ^3.x.x) and I've migrated tests from svelte ^2.x.x to svelte ^3.x.x.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Copy link
Owner

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'll merge it after you modify a few things.

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "svelte-jest",
"version": "0.2.0",
"version": "1.1.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this line because I will update the version number on release timing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

package.json Outdated
"eslint-config-prettier": "^6.0.0",
"jest": "^24.9.0",
"prettier": "1.18.2",
"svelte": "^3.8.1"
},
"peerDependencies": {
"svelte": "*"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change is not compatible with old version, can you update the peerDep to svelte@^3.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I didn't notice that 👍

Copy link
Owner

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ktsn ktsn merged commit d37a924 into ktsn:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants