-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #3
Conversation
d7c07b6
to
73e8985
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I'll merge it after you modify a few things.
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "svelte-jest", | |||
"version": "0.2.0", | |||
"version": "1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this line because I will update the version number on release timing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
package.json
Outdated
"eslint-config-prettier": "^6.0.0", | ||
"jest": "^24.9.0", | ||
"prettier": "1.18.2", | ||
"svelte": "^3.8.1" | ||
}, | ||
"peerDependencies": { | ||
"svelte": "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this change is not compatible with old version, can you update the peerDep to svelte@^3.0.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I didn't notice that 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Hi, I've updated dependencies (mostly what matters is
svelte ^3.x.x
) and I've migrated tests fromsvelte ^2.x.x
tosvelte ^3.x.x
.Type of change