Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add persistency for list of already analyzed posts #4

Closed
ktos opened this issue Oct 15, 2019 · 2 comments · Fixed by #14
Closed

Add persistency for list of already analyzed posts #4

ktos opened this issue Oct 15, 2019 · 2 comments · Fixed by #14
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.7

Comments

@ktos
Copy link
Owner

ktos commented Oct 15, 2019

At the moment list of already analyzed posts is only in memory and is lost after exit. Should be persisted somehow.
@ktos ktos added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2019
@ktos ktos added this to the v0.6 milestone Oct 23, 2019
@AFM-Horizon
Copy link
Contributor

AFM-Horizon commented Oct 24, 2019 •
edited
Loading

Gday Ktos, I'm happy to have a look at this if you want! Any preference for persistence technology?

@ktos
Copy link
Owner Author

ktos commented Oct 24, 2019 •
edited
Loading

Oh, that'd be great!

Actually, I don't care about technology that much, but I'd prefer something simple, don't use MSSQL ;)

Some single-file thing would be the best - JSON? text file? SQLite? To be honest, I'm not sure which to choose.

@ktos ktos modified the milestones: v0.6, v0.7 Oct 25, 2019
@ktos ktos mentioned this issue Oct 26, 2019
Merged
@ktos ktos closed this as completed in #14 Oct 27, 2019
ktos added a commit that referenced this issue Oct 27, 2019
@ktos
Add serialization and deserialization of ids of already analyzed posts (
d1342fb 
#14)

Adds serialization and deserialization of already analyzed post_ids to achieve some kind of persistency between runs (closes #4). Everything is saved into one file, analyzed.bin.

Database is also saved on Ctrl+C press.

There is also a commandline option --ignoreAlreadyAnalyzed which is ignoring loading and saving this database.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.7
Development

Successfully merging a pull request may close this issue.

Add serialization and deserialization of ids of already analyzed posts ktos/Eleia
2 participants
@ktos @AFM-Horizon