KTOR-7104 Fix saving caches with different vary header #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjhham
approved these changes
Feb 13, 2025
…pdated-when-Vary-header-for-304-response-matches-but-not-equal-to-Vary-for-200-response
marychatte
deleted the
marychatte/KTOR-7104-HttpCache-Cache-isn't-updated-when-Vary-header-for-304-response-matches-but-not-equal-to-Vary-for-200-response
branch
bjhham
pushed a commit
that referenced
this pull request
Feb 19, 2025
anton-erofeev
pushed a commit
to anton-erofeev/ktor
that referenced
this pull request
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client, Cache
Motivation
KTOR-7104
In the issue it's said:
But actually, it shouldn't update the cache as well as it shouldn't respond with cached data because in documentation we can find the next: