Prefer ts

[ktmud]

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

[github-actions]

WARNING: Prefer TypeScript

It looks like your PR contains new .js or .jsx files:

superset-frontend/src/test.js

As decided in SIP-36,
all new files should be written in TypeScript. Please convert new JavaScript
files to TypeScript and then re-request review.

[codecov]

Codecov Report

Merging #153 into master will decrease coverage by 0.00%.
The diff coverage is 74.21%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
- Coverage   70.52%   70.51%   -0.01%     
==========================================
  Files         594      594              
  Lines       31428    31444      +16     
  Branches     3215     3222       +7     
==========================================
+ Hits        22165    22174       +9     
- Misses       9147     9154       +7     
  Partials      116      116              

Flag	Coverage Δ
#cypress	53.47% <31.81%> (-0.02%)	⬇️
#javascript	59.63% <45.45%> (-0.02%)	⬇️
#python	70.33% <80.18%> (+<0.01%)	⬆️

Impacted Files	Coverage Δ
...rset-frontend/src/SqlLab/components/QueryTable.jsx	61.53% <0.00%> (+2.27%)	⬆️
...end/src/SqlLab/components/RunQueryActionButton.tsx	68.18% <0.00%> (-3.25%)	⬇️
superset/models/sql_lab.py	92.74% <ø> (ø)
superset/queries/api.py	100.00% <ø> (ø)
superset/tasks/thumbnails.py	40.74% <20.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js	60.68% <27.27%> (-0.98%)	⬇️
superset/connectors/sqla/views.py	81.67% <68.42%> (ø)
superset/connectors/sqla/models.py	89.25% <86.27%> (+0.13%)	⬆️
superset/security/manager.py	90.82% <86.95%> (+0.05%)	⬆️
...rontend/src/SqlLab/components/TabbedSqlEditors.jsx	81.16% <87.50%> (+0.21%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16cffd0...bd1c38a. Read the comment docs.

[github-actions]

Action Needed: Prefer TypeScript

It looks like your PR contains new .js or .jsx files:

superset-frontend/src/test.js

As decided in SIP-36, all new files should be written in TypeScript.

Please convert these files to TypeScript then re-request review.

[cypress]

---

Test summary

29 • 0 • 10 • 0

---

Run details

Project	Superset
Status	Passed
Commit	bd1c38a
Started	Jun 25, 2020 10:05 PM
Ended	Jun 25, 2020 10:09 PM
Duration	04:36 💡
OS	Linux Ubuntu Linux - 18.04
Browser	Chrome 83

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[github-actions]

[Action Needed] Prefer TypeScript

Looks like your PR contains new .js or .jsx files:

superset-frontend/src/test.js

As decided in SIP-36, all new frontend code should be written in TypeScript. Please convert above files to TypeScript then re-request review.

[cypress]

---

Test summary

29 • 0 • 10 • 0

---

Run details

Project	Superset
Status	Passed
Commit	56d5a2848c ℹ️
Started	Jun 25, 2020 10:04 PM
Ended	Jun 25, 2020 10:08 PM
Duration	04:12 💡
OS	Linux Ubuntu Linux - 18.04
Browser	Chrome 83

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard