chore: enable eslint-import-resolver-typescript (apache#10895)

Let eslint understand tsconfig.json when importing modules, so we can use `compilerOption.paths` to override where to find ts modules.
ktmud · Sep 15, 2020 · 4eeee4c · 4eeee4c
1 parent c43992b
commit 4eeee4c
Show file tree

Hide file tree

Showing 5 changed files with 60 additions and 1 deletion.
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
@@ -127,7 +127,10 @@ module.exports = {
         'prettier/prettier': 'error',
       },
       settings: {
-        'import/resolver': 'webpack',
+        'import/resolver': {
+          webpack: {},
+          typescript: {},
+        },
         react: {
           version: 'detect',
         },

diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -235,6 +235,7 @@
     "eslint": "^7.8.1",
     "eslint-config-airbnb": "^18.2.0",
     "eslint-config-prettier": "^6.11.0",
+    "eslint-import-resolver-typescript": "^2.3.0",
     "eslint-import-resolver-webpack": "^0.12.2",
     "eslint-plugin-cypress": "^2.11.1",
     "eslint-plugin-import": "^2.22.0",

diff --git a/superset-frontend/src/explore/components/controls/TextAreaControl.jsx b/superset-frontend/src/explore/components/controls/TextAreaControl.jsx
@@ -65,6 +65,7 @@ export default class TextAreaControl extends React.Component {
       this.onAceChange(value);
     }, 300);
   }
+
   onControlChange(event) {
     this.props.onChange(event.target.value);
   }

diff --git a/superset-frontend/src/featureFlags.ts b/superset-frontend/src/featureFlags.ts
@@ -33,6 +33,7 @@ export type FeatureFlagMap = {
   [key in FeatureFlag]?: boolean;
 };
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 declare global {
   interface Window {
     featureFlags: FeatureFlagMap;