Add toasts and login form #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arsenicro
suggested changes
Jul 14, 2024
ref-humbold
reviewed
Jul 23, 2024
ref-humbold
reviewed
Jul 23, 2024
ref-humbold
reviewed
Jul 23, 2024
| "user": { | ||
| "is_authenticated": request.user.is_authenticated, | ||
| "is_staff": request.user.is_staff, | ||
| "email": request.user.email if not request.user.is_anonymous else "", |
There was a problem hiding this comment.
I think request.user.is_anonymous or "" will suffice.
Applies to request.user.first_name and request.user.last_name` as well.
There was a problem hiding this comment.
I don't really understand.
If you mean "email": request.user.is_anonymous or "", then it doesn't make sense, because we need to provide the request.user.email value
If you mean "email": request.user.email or "", then it also won't work, because if user is anonymous the user.email field doesn't exist (since then user is of type AnonymousUser, not User), so we get an exception.
Arsenicro
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
messages.<message_level>()/loginform with some code that automatically generates frontend code from Django's forms<CenteredContainer/>component, which caps width of elements based on screen size. I also refactored many other components to use it, so that the entire website behaves consistently with different screen sizes.context.user.some_property, rather thancontext.some_property). Custom context processors are not well documented in Reactivated, so I initially missed the fact that it can be achieved this way.