fix: verbose level ignored on update / finish

kshutkin · Dec 2, 2021 · b6023e3 · b6023e3
1 parent c09caa4
commit b6023e3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/logger/src/core.ts b/logger/src/core.ts
@@ -26,11 +26,11 @@ export function createLogger<ErrorContext = Error>(...args: [] | [string | Ident
             },
             // Fine to be updated multiple times
             update(message: string, loglevel?: LogLevel) {
-                append(message, Action.update, loglevel || initialLogLevel);
+                append(message, Action.update, loglevel ?? initialLogLevel);
             },
             // Fine to be finished multiple times
             finish(message: string, loglevel?: LogLevel) {
-                append(message, Action.finish, loglevel || initialLogLevel);
+                append(message, Action.finish, loglevel ?? initialLogLevel);
             },
             withFilter(predicate: (logMessage: LogMessage<ErrorContext>) => boolean) {
                 myAppender = filterMessages(predicate, myAppender);

diff --git a/logger/tests/logger.spec.ts b/logger/tests/logger.spec.ts
@@ -109,6 +109,21 @@ describe('api tests', () => {
                 })
             );
         });
+
+        it('with overriden log level', () => {
+            const appenderMock = jest.fn();
+            appender(appenderMock);
+            createLogger().start('test message', LogLevel.info);
+            createLogger().start('test message2', LogLevel.verbose);
+            expect(appenderMock).toBeCalledWith(
+                expect.objectContaining({
+                    action: Action.start, 
+                    inputId: expect.any(Number), 
+                    loglevel: LogLevel.verbose, 
+                    message: 'test message2'
+                })
+            );
+        });
     });
 
     describe('update', () => {