UI: TextField Fix the cursor #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ksharma-xyz and the rest of your teammates on |
ksharma-xyz
force-pushed
the
09-29-ui_textfield_fix_the_cursor
branch
from
145708a to
43bfe42
Compare
ksharma-xyz
added
UI
ksharma-xyz
force-pushed
the
09-29-ui_textfield_fix_the_cursor
branch
from
43bfe42 to
dbb82e8
Compare
Cursor always displayed at the start of Placeholder Cursor dislayed as soon as the field is focused.
ksharma-xyz
force-pushed
the
09-29-ui_textfield_fix_the_cursor
branch
from
dbb82e8 to
85608e5
Compare
ksharma-xyz
added a commit
that referenced
this pull request
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Problem:
When using
BasicTextFielddirectly, the cursor is only shown by default when there's text or during text input, i.e when it is in focused state.We need to ensure that the cursor is always visible when the
TextFieldis in focused state, this means displaying the cursor at the beginning even when the placeholder text is displayed.Before - No cursor by default
NoCursor.by.default.mov
After
Cursor_After.mov