Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add 2025 festival dates for TimeTable loading screen #562

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 24, 2025

TL;DR

Added 2025 festival dates for Chinese New Year and labeled existing festival dates.

What changed?

  • Extended Chinese New Year celebration period from January 29 to February 6, 2025
  • Added year labels to existing festival dates (Easter 2025, Vivid Sydney 2025)

How to test?

  1. Launch the app during Chinese New Year period (Jan 29 - Feb 6, 2025)
  2. Verify that appropriate festival emojis appear during loading screens
  3. Confirm loading emojis appear correctly for other labeled festivals (Easter, Vivid Sydney)

Why make this change?

To ensure the app displays culturally appropriate loading animations during the extended Chinese New Year celebration period in 2025 and to improve code clarity by explicitly labeling festival years.

@ksharma-xyz ksharma-xyz changed the title Add chinese new year for emoji festival UI: Add 2025 festival dates for loading screen Jan 24, 2025
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title UI: Add 2025 festival dates for loading screen UI: Add 2025 festival dates for TimeTable loading screen Jan 24, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 24, 2025 08:32
@ksharma-xyz ksharma-xyz merged commit 077b892 into main Jan 24, 2025
4 checks passed
Copy link
Owner Author

Merge activity

  • Jan 24, 3:43 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 01-24-add_chinese_new_year_for_emoji_festival branch January 24, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant