Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Replace klickable with scalingKlickable in radio buttons #560

Merged
merged 1 commit into from
Jan 23, 2025
Merged

UI: Replace klickable with scalingKlickable in radio buttons #560

merged 1 commit into from
Jan 23, 2025

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 22, 2025 •
edited
Loading

TL;DR

Updated click interactions in the Trip Planner UI to include scaling animations

What changed?

  • Replaced standard klickable modifier with scalingKlickable in OutlineRadioButton
  • Updated TransportModeRadioButton to use scalingKlickable for enhanced touch feedback

How to test?

  1. Navigate to the Theme Selection screen
  2. Tap on different transport mode options
  3. Verify that buttons now scale slightly when pressed
  4. Confirm that the outline radio buttons have the same scaling behavior

Why make this change?

To improve touch feedback and create a more engaging user experience by adding subtle scaling animations to interactive elements in the Trip Planner interface

This was referenced Jan 22, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@ksharma-xyz Graphite App
Copy link
Owner Author

ksharma-xyz commented Jan 22, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz mentioned this pull request Jan 22, 2025
Merged
@ksharma-xyz ksharma-xyz force-pushed the 01-22-create_scaling_button branch from 64c6304 to 2a7aa6c Compare January 22, 2025 11:54
@ksharma-xyz ksharma-xyz force-pushed the 01-22-use_scaling_klickable_in_outlined_radio_button branch from c5cd17d to 78b353f Compare January 22, 2025 11:57
@ksharma-xyz ksharma-xyz force-pushed the 01-22-create_scaling_button branch from 2a7aa6c to 0d23013 Compare January 23, 2025 08:32
@ksharma-xyz ksharma-xyz force-pushed the 01-22-use_scaling_klickable_in_outlined_radio_button branch from 78b353f to de33768 Compare January 23, 2025 08:32
@ksharma-xyz ksharma-xyz changed the title Use scaling klickable in outlined radio button UI: Replace klickable with scalingKlickable in radio buttons Jan 23, 2025
@ksharma-xyz ksharma-xyz marked this pull request as ready for review January 23, 2025 08:33
@ksharma-xyz ksharma-xyz force-pushed the 01-22-create_scaling_button branch from 0d23013 to f962ef4 Compare January 23, 2025 08:44
@ksharma-xyz ksharma-xyz force-pushed the 01-22-use_scaling_klickable_in_outlined_radio_button branch from de33768 to 61e6b85 Compare January 23, 2025 08:45
@ksharma-xyz ksharma-xyz changed the base branch from 01-22-create_scaling_button to graphite-base/560 January 23, 2025 08:55
@ksharma-xyz ksharma-xyz force-pushed the 01-22-use_scaling_klickable_in_outlined_radio_button branch from 61e6b85 to 59b6fd5 Compare January 23, 2025 08:55
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/560 to main January 23, 2025 08:56
@ksharma-xyz ksharma-xyz force-pushed the 01-22-use_scaling_klickable_in_outlined_radio_button branch from 59b6fd5 to ed559e0 Compare January 23, 2025 08:56
@ksharma-xyz ksharma-xyz merged commit aa9f01b into main Jan 23, 2025
2 checks passed
@ksharma-xyz Graphite App
Copy link
Owner Author

Merge activity

  • Jan 23, 4:07 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 01-22-use_scaling_klickable_in_outlined_radio_button branch January 23, 2025 09:07
@ksharma-xyz ksharma-xyz added this to the 1.0.6 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Krail - NSW Trip Planning
Status: Done
Milestone
1.0.6
Development

Successfully merging this pull request may close these issues.
1 participant
@ksharma-xyz