Test: Add ServiceAlertsViewModel tests and make toServiceAlert public #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 10, 2025
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
01-10-add_ut_for_selectedtransportmode_for_theme
branch
from
ec21e47 to
298513e
Compare
ksharma-xyz
force-pushed
the
01-10-add_ut_for_servicealertvm
branch
from
b088b6b to
ab69f5b
Compare
Base automatically changed from
01-10-add_ut_for_selectedtransportmode_for_theme
to
main
January 11, 2025 01:00
ksharma-xyz
force-pushed
the
01-10-add_ut_for_servicealertvm
branch
from
ab69f5b to
6ca256b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added unit tests for ServiceAlertsViewModel and made toServiceAlert function public.
What changed?
toServiceAlert()function public to support testingHow to test?
Why make this change?
To ensure the ServiceAlertsViewModel behaves correctly and maintains proper state management. This change improves test coverage and helps catch potential regressions in the service alerts functionality.