Test: Add SearchStopViewModel tests and fake stop finder response builder #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksharma-xyz
changed the title
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added test coverage for SearchStopViewModel and enhanced FakeAnalytics tracking capabilities
What changed?
FakeAnalyticsto store and retrieve completeAnalyticsEventobjects instead of just event namesFakeStopFinderResponseBuilderto generate test data for stop finder responsesFakeTripPlanningServiceto use the new response builderSearchStopViewModelcovering:How to test?
SearchStopViewModelTestWhy make this change?
To ensure reliable behavior of the SearchStopViewModel through comprehensive test coverage, particularly focusing on user interactions, API responses, and analytics tracking. This change improves the overall reliability and maintainability of the search stop feature.