Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Remove iosX64 target from trip planner network module #525

Merged

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Jan 10, 2025

TL;DR

Removed iOS x64 architecture support from trip planner network module

What changed?

Removed iosX64() target from the Kotlin Multiplatform configuration in the trip planner network module's build file

How to test?

  1. Build the iOS app for arm64 devices and simulator
  2. Verify the app builds successfully
  3. Confirm the app runs on modern iOS devices and simulators

Why make this change?

iOS x64 architecture is no longer needed as Apple has transitioned to arm64 for all modern devices and simulators. Removing this target simplifies the build process and reduces unnecessary compilation time.

@ksharma-xyz ksharma-xyz changed the title Remove iosX64() target from trip-planner:network module Build: Remove iosX64 target from trip planner network module Jan 10, 2025
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Owner Author

ksharma-xyz commented Jan 10, 2025

Merge activity

  • Jan 9, 8:52 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 9, 8:54 PM EST: Graphite rebased this pull request as part of a merge.
  • Jan 9, 9:07 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz force-pushed the 01-10-remove_iosx64_target_from_trip-planner_network_module branch from 59f92ea to 83391c8 Compare January 10, 2025 01:53
@ksharma-xyz ksharma-xyz merged commit 7f2a198 into main Jan 10, 2025
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 01-10-remove_iosx64_target_from_trip-planner_network_module branch January 10, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant