Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DI: Move Koin Android context initialization to MainActivity #507

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,13 @@ class KrailApplication : Application() {

override fun onCreate() {
super.onCreate()
instance = this
// instance = this
Firebase.initialize(context = this)
}

/*
companion object {
var instance: Application? = null
}
*/
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,20 @@ import android.os.Bundle
import androidx.activity.ComponentActivity
import androidx.activity.compose.setContent
import androidx.activity.enableEdgeToEdge
import org.koin.android.ext.koin.androidContext
import org.koin.android.ext.koin.androidLogger
import org.koin.core.logger.Level

class MainActivity : ComponentActivity() {

override fun onCreate(savedInstanceState: Bundle?) {
enableEdgeToEdge()
super.onCreate(savedInstanceState)
setContent {
KrailApp()
KrailApp {
androidContext(this@MainActivity)
androidLogger(Level.DEBUG)
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,11 +1,8 @@
package xyz.ksharma.krail.di

import org.koin.android.ext.koin.androidContext
import org.koin.android.ext.koin.androidLogger
import org.koin.dsl.koinConfiguration
import xyz.ksharma.krail.KrailApplication

actual fun nativeConfig() = koinConfiguration {
androidLogger()
androidContext(KrailApplication.instance ?: error("No Android application context set"))
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@ package xyz.ksharma.krail

import androidx.compose.runtime.Composable
import org.koin.compose.KoinApplication
import org.koin.dsl.KoinAppDeclaration
import xyz.ksharma.krail.di.koinConfig
import xyz.ksharma.krail.taj.theme.KrailTheme

@Composable
fun KrailApp() {
KoinApplication(application = koinConfig) {
fun KrailApp(koinDeclaration: KoinAppDeclaration? = null) {
KoinApplication(application = {
koinDeclaration?.invoke(this)
koinConfig()
}) {
KrailTheme {
KrailNavHost()
}
Expand Down
Loading