Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Replace println/Timber with unified logging system #472

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 19, 2024

TL;DR

Replaced all println and Timber logging calls with a unified log function from the core module.

What changed?

  • Replaced all instances of println debugging statements with log function calls
  • Removed Timber logging dependencies and replaced with log function
  • Updated logging calls across trip planner, GTFS, and UI components
  • Standardized error logging format
  • Added imports for the new logging utility

How to test?

  1. Run the app and verify logging output appears correctly
  2. Check debug logs in various scenarios:
    • Search for stops
    • View timetables
    • Save trips
    • Download GTFS data
  3. Verify error messages are properly logged during failure cases

Why make this change?

Centralizing logging through a single utility function provides:

  • Consistent logging format across the codebase
  • Better control over logging output
  • Easier debugging and log filtering
  • Removal of Android-specific Timber dependency for better multiplatform support

@ksharma-xyz ksharma-xyz changed the title Use log in the modules Core: Replace println/Timber with unified logging system Dec 19, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 19, 2024 07:05
@ksharma-xyz ksharma-xyz force-pushed the 12-19-create_core_log_module branch from ee81a8a to e447bf3 Compare December 21, 2024 02:17
Base automatically changed from 12-19-create_core_log_module to main December 21, 2024 19:47
Copy link
Owner Author

Merge activity

  • Dec 22, 4:11 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@ksharma-xyz ksharma-xyz force-pushed the 12-19-use_log_in_the_modules branch from 567f8cb to ab5e4c7 Compare December 23, 2024 11:59
@ksharma-xyz ksharma-xyz merged commit 93feba8 into main Dec 23, 2024
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 12-19-use_log_in_the_modules branch December 23, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant