Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTFS: Add file storage for gtfs static data downloads #449

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 11, 2024

TL;DR

Added GTFS static file download functionality for Sydney Trains data with platform-specific file storage implementations.

What changed?

  • Created a FileStorage interface with platform-specific implementations for Android and iOS
  • Implemented GTFS file downloading functionality in RealNswGtfsService
  • Added dependency injection modules for GTFS and file storage services
  • Integrated GTFS service into SavedTripsViewModel for initial testing
  • Removed BuildKonfig plugin and related API key configuration as it was duplicate

How to test?

  1. Launch the app and navigate to the Saved Trips screen
  2. The app should attempt to download Sydney Trains GTFS data
  3. Verify that a "sydneytrains.zip" file is created in the app's files directory
  4. Check logs for "Downloading file" and "File downloaded" messages

Why make this change?

To enable offline access to transit schedule data by implementing the infrastructure needed to download and store GTFS static files locally on both Android and iOS platforms. This is a foundational step towards providing reliable trip planning functionality without constant network connectivity.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Add filestorage for gtfs static GTFS: Add file storage for static data downloads Dec 11, 2024
@ksharma-xyz ksharma-xyz changed the title GTFS: Add file storage for static data downloads GTFS: Add file storage for gtfs static data downloads Dec 11, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 11, 2024 10:24
@ksharma-xyz ksharma-xyz merged commit 8c67969 into main Dec 11, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Dec 11, 5:33 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 12-11-add_filestorage_for_gtfs_static branch December 11, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant