Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoRefresh TimeTable every 30 seconds when screen is active #424

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 4, 2024

TL;DR

Replaced manual time text updates with automatic time table refresh in the Trip Planner.

What changed?

  • Removed manual time text update logic that was updating individual journey cards
  • Introduced automatic time table refresh using rate limiter
  • Changed refresh interval from 5 seconds to 30 seconds
  • Renamed related variables and functions for clarity

Screenshots

Screen.Recording.2024-12-04.at.10.18.53.pm.mov

Why make this change?

The previous implementation updated only the time text of journey cards, which didn't account for potential changes in the actual journey data. By implementing a full refresh, we ensure that all journey information remains accurate and synchronized with the backend data.

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz changed the title Auto refresh TimeTable UI: Replace time text updates with auto-refresh mechanism Dec 4, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 4, 2024 11:20
@ksharma-xyz ksharma-xyz added this to the Release v1.0 iOS + Android milestone Dec 4, 2024
@ksharma-xyz ksharma-xyz changed the title UI: Replace time text updates with auto-refresh mechanism AutoRefresh TimeTable every 30 seconds when screen is active Dec 4, 2024
@ksharma-xyz ksharma-xyz merged commit 4f1151c into main Dec 4, 2024
2 checks passed
@ksharma-xyz ksharma-xyz deleted the 12-04-auto_refresh_timetable branch December 4, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant