Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add horizontal padding to alert heading text #413

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Dec 2, 2024

TL;DR

Added horizontal padding to alert heading text

What changed?

Modified the padding modifier for the alert heading text from start = 12.dp to horizontal = 12.dp, which adds padding to both left and right sides of the text.

How to test?

  1. Navigate to any screen displaying service alerts
  2. Verify that alert headings have equal padding on both left and right sides
  3. Ensure text remains properly aligned within the alert container

Why make this change?

To improve visual consistency and readability of alert headings by maintaining equal spacing on both sides of the text, rather than just the left side.

@ksharma-xyz ksharma-xyz changed the title Serive Alert title padding fix UI: Add horizontal padding to alert heading text Dec 2, 2024
Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ksharma-xyz ksharma-xyz marked this pull request as ready for review December 2, 2024 07:03
@ksharma-xyz ksharma-xyz added this to the Release v1.0 iOS + Android milestone Dec 2, 2024
@ksharma-xyz ksharma-xyz merged commit 4fab9d0 into main Dec 2, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Dec 2, 2:10 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 12-02-serive_alert_title_padding_fix branch December 2, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant