Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Enhance DateTime selector with reset and date navigation #398

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 29, 2024

TL;DR

Enhanced the date-time selector UI with improved formatting, navigation controls, and reset functionality.

What changed?

  • Added date navigation with next/previous controls and date bounds
  • Implemented a reset button to return to current date and time
  • Created new utility functions for date formatting and manipulation
  • Enhanced time display with proper AM/PM formatting
  • Updated typography and styling for better visual hierarchy
  • Added a "Done" button with themed styling
  • Removed redundant SelectedDateTimeRow component

Screenshots

Screen.Recording.2024-11-30.at.12.55.04.am.mov

Why make this change?

To provide a more intuitive and user-friendly date-time selection experience with better visual feedback and navigation controls. The changes improve accessibility and make it easier for users to select and modify their desired date and time.

Copy link
Owner Author

ksharma-xyz commented Nov 29, 2024

@ksharma-xyz ksharma-xyz force-pushed the 11-29-add_dateselection_logic branch from 2fffccd to 138490d Compare November 29, 2024 13:54
@ksharma-xyz ksharma-xyz changed the title Add DateSelection logic UI: Enhance DateTime selector with reset and date navigation Nov 29, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 29, 2024 13:56
@ksharma-xyz ksharma-xyz changed the base branch from 11-29-create_journeytimeoptionsgroup to graphite-base/398 November 29, 2024 13:57
@ksharma-xyz ksharma-xyz force-pushed the 11-29-add_dateselection_logic branch from 138490d to da52006 Compare November 29, 2024 13:57
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/398 to main November 29, 2024 13:57
@ksharma-xyz ksharma-xyz force-pushed the 11-29-add_dateselection_logic branch from da52006 to bbec75c Compare November 29, 2024 13:57
@ksharma-xyz ksharma-xyz merged commit 1f37762 into main Nov 29, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Nov 29, 9:07 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-29-add_dateselection_logic branch November 29, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant