Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Clear focus when exiting search stop screen #386

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 26, 2024

TL;DR

Added focus management when navigating away from the search stop screen

What changed?

Added focusRequester.freeFocus() calls when:

  • Clicking the back button
  • Selecting a stop from the search results

How to test?

  1. Open the search stop screen
  2. Type in the search field
  3. Click back button or select a stop
  4. Verify keyboard is dismissed and focus is cleared

Why make this change?

Improves the user experience by properly managing keyboard focus when navigating away from the search screen, preventing any lingering focus states that could affect the next screen.

Copy link
Owner Author

ksharma-xyz commented Nov 26, 2024

@ksharma-xyz ksharma-xyz changed the base branch from 11-26-tweak to graphite-base/386 November 26, 2024 12:15
@ksharma-xyz ksharma-xyz force-pushed the 11-26-keyboard_hide_updates branch from e19a7ad to 429051b Compare November 26, 2024 12:15
@ksharma-xyz ksharma-xyz changed the title Keyboard hide updates UI: Clear focus when exiting search stop screen Nov 26, 2024
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/386 to main November 26, 2024 12:16
@ksharma-xyz ksharma-xyz force-pushed the 11-26-keyboard_hide_updates branch from 429051b to 4e464b1 Compare November 26, 2024 12:16
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 26, 2024 12:16
@ksharma-xyz ksharma-xyz merged commit e6e30e9 into main Nov 26, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Nov 26, 7:24 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-26-keyboard_hide_updates branch November 26, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant