Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Redesign CollapsibleAlert and improve HTML text styling #376

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 24, 2024

TL;DR

Enhanced the visual appearance and functionality of service alerts in the trip planner UI.

What changed?

  • Redesigned the CollapsibleAlert component with a semi-transparent background and rounded corners
  • Added a "Read More" button for collapsed alerts
  • Updated HtmlText component to support customizable text and URL colors
  • Improved text alignment and spacing in alert displays
  • Enhanced contrast between background and foreground colors for better readability

How to test?

  1. Navigate to the trip planner service alerts screen
  2. Verify alerts display with semi-transparent backgrounds
  3. Check that collapsed alerts show a "Read More" button
  4. Confirm text is readable and properly aligned
  5. Test that HTML links are properly colored and clickable
  6. Verify alerts expand/collapse smoothly when tapped

Why make this change?

To improve the user experience by making service alerts more visually appealing and easier to read. The addition of the "Read More" button makes it clearer that alerts are expandable, while the enhanced color contrast ensures better accessibility.

@ksharma-xyz ksharma-xyz mentioned this pull request Nov 24, 2024
Copy link
Owner Author

ksharma-xyz commented Nov 24, 2024

@ksharma-xyz ksharma-xyz changed the title update collapsible alert UI: Redesign CollapsibleAlert and improve HTML text styling Nov 24, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 24, 2024 12:59
@ksharma-xyz ksharma-xyz force-pushed the 11-24-add_loading_state_to_saved_trips branch 2 times, most recently from 0f90934 to 3bb6c89 Compare November 24, 2024 22:02
@ksharma-xyz ksharma-xyz force-pushed the 11-24-update_collapsible_alert branch from c960b6e to 0aa22b8 Compare November 24, 2024 22:02
@ksharma-xyz ksharma-xyz changed the base branch from 11-24-add_loading_state_to_saved_trips to graphite-base/376 November 24, 2024 22:09
@ksharma-xyz ksharma-xyz force-pushed the 11-24-update_collapsible_alert branch from 0aa22b8 to 927ec01 Compare November 24, 2024 22:09
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/376 to main November 24, 2024 22:10
@ksharma-xyz ksharma-xyz force-pushed the 11-24-update_collapsible_alert branch from 927ec01 to 7aa536f Compare November 24, 2024 22:10
@ksharma-xyz ksharma-xyz merged commit 9d796bb into main Nov 24, 2024
2 checks passed
Copy link
Owner Author

Merge activity

  • Nov 24, 5:18 PM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-24-update_collapsible_alert branch November 24, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant