Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Improve stop search results handling and animations #334

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Nov 11, 2024

TL;DR

Enhanced the stop search functionality with improved error handling and smoother UI transitions.

What changed?

  • Added key-based list item rendering for better performance
  • Implemented a 1-second delay before showing "No match found" message
  • Added tracking of query timestamps to prevent false "No match found" displays
  • Improved error state handling with distinct keys for error messages
  • Removed redundant Unit placeholder for empty state

How to test?

  1. Open the stop search screen
  2. Enter a search query
  3. Verify that "No match found" appears after 1 second if no results
  4. Enter a valid stop name and confirm results appear
  5. Clear the search and verify smooth transitions
  6. Test with network errors to verify error message display

Screenshots

Screen.Recording.2024-11-12.at.12.11.19.am.mov

Why make this change?

To provide a more polished user experience by eliminating UI flicker, improving state transitions, and ensuring more reliable error handling when searching for stops.

Copy link
Owner Author

ksharma-xyz commented Nov 11, 2024

@ksharma-xyz ksharma-xyz changed the title ISsue - going to else condition UI: Improve stop search results handling and animations Nov 11, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review November 11, 2024 13:09
@ksharma-xyz ksharma-xyz added the UI Design System Related changes label Nov 11, 2024
@ksharma-xyz ksharma-xyz force-pushed the 11-11-issue_-_going_to_else_condition branch from 15cd968 to 0411fba Compare November 11, 2024 13:15
@ksharma-xyz ksharma-xyz force-pushed the 11-11-add_filter_logic_to_textfield branch 2 times, most recently from 3f824fd to 735e1b4 Compare November 11, 2024 13:16
@ksharma-xyz ksharma-xyz force-pushed the 11-11-issue_-_going_to_else_condition branch from 0411fba to f2dd193 Compare November 11, 2024 13:16
@ksharma-xyz ksharma-xyz force-pushed the 11-11-add_filter_logic_to_textfield branch from 735e1b4 to dd4f23e Compare November 11, 2024 13:20
@ksharma-xyz ksharma-xyz force-pushed the 11-11-issue_-_going_to_else_condition branch from f2dd193 to 3d9fd71 Compare November 11, 2024 13:20
@ksharma-xyz ksharma-xyz changed the base branch from 11-11-add_filter_logic_to_textfield to graphite-base/334 November 11, 2024 13:26
@ksharma-xyz ksharma-xyz force-pushed the 11-11-issue_-_going_to_else_condition branch from 3d9fd71 to 795981c Compare November 11, 2024 13:27
@ksharma-xyz ksharma-xyz changed the base branch from graphite-base/334 to main November 11, 2024 13:27
@ksharma-xyz ksharma-xyz force-pushed the 11-11-issue_-_going_to_else_condition branch from 795981c to 044a0ac Compare November 11, 2024 13:27
@ksharma-xyz ksharma-xyz merged commit c7be280 into main Nov 11, 2024
3 checks passed
Copy link
Owner Author

Merge activity

  • Nov 11, 8:35 AM EST: A user merged this pull request with Graphite.

@ksharma-xyz ksharma-xyz deleted the 11-11-issue_-_going_to_else_condition branch November 11, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Design System Related changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant