UI: Change screen backgrounds from background to surface color #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 31, 2024
This was referenced Oct 31, 2024
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
36b1bab to
1fe3fd1
Compare
ksharma-xyz
force-pushed
the
10-31-change_background_colors
branch
from
b6e0352 to
da8af74
Compare
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
from
1fe3fd1 to
db4ce93
Compare
ksharma-xyz
force-pushed
the
10-31-change_background_colors
branch
from
da8af74 to
bfb9f1a
Compare
ksharma-xyz
force-pushed
the
10-31-add_star_button_to_save_trip_on_timetablescreen
branch
2 times, most recently
from
8cbc12e to
c4de318
Compare
ksharma-xyz
force-pushed
the
10-31-change_background_colors
branch
from
bfb9f1a to
6e3ce14
Compare
ksharma-xyz
changed the base branch from
10-31-add_star_button_to_save_trip_on_timetablescreen
to
graphite-base/276
ksharma-xyz
force-pushed
the
graphite-base/276
branch
from
c4de318 to
ee6e638
Compare
ksharma-xyz
force-pushed
the
10-31-change_background_colors
branch
from
6e3ce14 to
603d3f8
Compare
ksharma-xyz
force-pushed
the
10-31-change_background_colors
branch
from
603d3f8 to
d3a48ee
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Updated screen backgrounds to use surface color instead of background color in the Trip Planner UI
What changed?
Changed the background color property from
KrailTheme.colors.backgroundtoKrailTheme.colors.surfacein:Why make this change?
Using the surface color provides better visual hierarchy and follows Material Design guidelines more closely, where surface colors are typically used for components that rest on top of the background