UI: Add transportModeBackgroundColor function and adjust LegView background #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ksharma-xyz and the rest of your teammates on |
ksharma-xyz
changed the title
ksharma-xyz
force-pushed
the
10-30-calculate_color_code_using_transport_mode
branch
from
30040ff to
40218f8
Compare
ksharma-xyz
force-pushed
the
10-30-calculate_color_code_using_transport_mode
branch
2 times, most recently
from
b041be4 to
df50b05
Compare
ksharma-xyz
force-pushed
the
10-30-calculate_color_code_using_transport_mode
branch
from
df50b05 to
9afb97b
Compare
ksharma-xyz
deleted the
10-30-calculate_color_code_using_transport_mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added a new function for transport mode background color and updated LegView background color logic.
What changed?
transportModeBackgroundColorfunction inColorExt.ktthat returns a color based on the transport mode and current theme (light/dark).LegViewcomponent inLegView.ktto use the system's dark theme setting for determining background color opacity.LegView.Why make this change?
This change improves the visual consistency of the app across different system themes. By adjusting the background color opacity based on the theme, we enhance readability and user experience in both light and dark modes. The new
transportModeBackgroundColorfunction also centralizes the logic for determining the appropriate background color, making it easier to maintain and update in the future.Screenshots