UI: Refine leg filtering and add debug logging in TripResponseMapper #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ksharma-xyz and the rest of your teammates on |
ksharma-xyz
force-pushed
the
10-27-for_walkingleg_the_stopsequence_will_always_be_null_therefore_it_should_not_fileter_the_valid_legs
branch
from
32f5831 to
db2f12f
Compare
…ould not fileter the valid legs.
ksharma-xyz
force-pushed
the
10-27-for_walkingleg_the_stopsequence_will_always_be_null_therefore_it_should_not_fileter_the_valid_legs
branch
from
db2f12f to
62b93a1
Compare
ksharma-xyz
changed the title
ksharma-xyz
added
the
improvement
Graphite App
ksharma-xyz
deleted the
10-27-for_walkingleg_the_stopsequence_will_always_be_null_therefore_it_should_not_fileter_the_valid_legs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
If the first leg is a walking leg, then it does not have any stop sequence and especially for Metro and Train. In those cases the walking leg was getting filtered out from
val legs = journey.getFilteredValidLegs()and not getting mapped ot Model inprivate fun TripResponse.Leg.toUiModel().Since only Public Transport legs have stopSequence it can be safely removed from the filter logic.
What changed?
getFilteredValidLegs()function to only filter legs based on transportation, removing the check forstopSequence.toUiModel()function to provide more information about each leg during the mapping process.Why make this change?
This change aims to improve the accuracy of leg filtering and provide better debugging capabilities. By removing the
stopSequencecheck, we ensure that valid legs with transportation information are not accidentally filtered out. The added logging will help in troubleshooting and understanding the leg mapping process more effectively.