Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add borders to Journey Card based on the Tansport Mode #203

Merged

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 18, 2024

TL;DR

Enhanced JourneyCard component with dynamic transport mode visualization and improved UI elements.

What changed?

  • Added a gradient border to the JourneyCard based on the transport modes used in the journey.
  • Replaced the transportModeIconRow parameter with a transportModeList of type ImmutableList<TransportMode>.
  • Dynamically generate transport mode icons based on the provided list.
  • Updated the color of the time to departure and platform number to match the first transport mode's color.
  • Modified preview functions to use the new transportModeList parameter.

Why make this change?

This change improves the visual representation of multi-modal journeys, making it easier for users to quickly identify the types of transport involved. The dynamic color scheme and gradient border enhance the overall user experience by providing a more intuitive and visually appealing interface. Additionally, the use of an ImmutableList for transport modes allows for more efficient and type-safe data handling.

Screenshots

Screenshot 2024-10-19 at 12 25 16 am

Copy link
Owner Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 18, 2024 13:22
@ksharma-xyz ksharma-xyz added the UI Design System Related changes label Oct 18, 2024
@ksharma-xyz ksharma-xyz force-pushed the 10-19-add_borders_to_journey_card_based_on_the_tansport_mode branch from 0b4403b to 3ba08e2 Compare October 18, 2024 13:26
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) October 18, 2024 13:26
@ksharma-xyz ksharma-xyz merged commit cd9f164 into main Oct 18, 2024
1 check passed
@ksharma-xyz ksharma-xyz deleted the 10-19-add_borders_to_journey_card_based_on_the_tansport_mode branch October 18, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Design System Related changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant