Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JourneyCard for improved flexibility and accessibility #181

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

ksharma-xyz
Copy link
Owner

@ksharma-xyz ksharma-xyz commented Oct 14, 2024

Refactor JourneyCard for improved flexibility and accessibility

This PR refactors the JourneyCard component to enhance its flexibility and accessibility. Key changes include:

  • Replace Row with FlowRow for responsiveness
  • Separate departure time and location text
  • Add origin and destination time text
  • Improve text styling and color consistency
  • Enhance layout for better readability at different font scales
  • Update TimeTableScreen to use the new JourneyCard structure
  • Improve null safety in TripResponseMapper

Screenshots

Screenshot 2024-10-15 at 8 42 09 am

Testing Notes

  • Verify that the JourneyCard displays correctly at different font scales
  • Ensure that the TimeTableScreen functions properly with the updated JourneyCard
  • Check that the TripResponseMapper handles null values appropriately

Copy link
Owner Author

ksharma-xyz commented Oct 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ksharma-xyz and the rest of your teammates on Graphite Graphite

@ksharma-xyz ksharma-xyz mentioned this pull request Oct 14, 2024
@ksharma-xyz ksharma-xyz marked this pull request as ready for review October 14, 2024 21:43
@ksharma-xyz ksharma-xyz changed the title Update UI of JourneyCard Refactor JourneyCard for improved flexibility and accessibility Oct 14, 2024
Base automatically changed from 10-14-create_constants to main October 14, 2024 21:44
@ksharma-xyz ksharma-xyz force-pushed the 10-14-update_ui_of_journeycard branch from 7ec78b7 to d0330b4 Compare October 14, 2024 21:45
@ksharma-xyz ksharma-xyz enabled auto-merge (squash) October 14, 2024 21:45
@ksharma-xyz ksharma-xyz added the UI Design System Related changes label Oct 14, 2024
@ksharma-xyz ksharma-xyz merged commit a0db335 into main Oct 14, 2024
1 check passed
@ksharma-xyz ksharma-xyz deleted the 10-14-update_ui_of_journeycard branch October 14, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Design System Related changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant