Update the manifests for KF release #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kimonas Sotirchos <[email protected]>
Signed-off-by: Kimonas Sotirchos <[email protected]>
|
/lgtm |
|
@StefanoFioravanzo: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, StefanoFioravanzo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Is @StefanoFioravanzo in the Kserve org? Looks like he's not a collaborator for this repo, so he can't do lgtm |
|
/lgtm |
|
Ah, this makes sense. Thanks! |
This was referenced Feb 25, 2022
kimwnasptd
added a commit
to kimwnasptd/models-web-app
that referenced
this pull request
Jul 20, 2022
* rename web-app to base in manifests Signed-off-by: Kimonas Sotirchos <[email protected]> * rename the path of the app Signed-off-by: Kimonas Sotirchos <[email protected]>
kserve-oss-bot
pushed a commit
that referenced
this pull request
Jul 20, 2022
* manifests: Update to v0.8.0 tag Signed-off-by: Kimonas Sotirchos <[email protected]> * manifests: Update gateways and prefix (#32) * manifests: Use explicit gateways Replace the variable substitution for the web app and hardcode the Gateway that will be used in each case. Signed-off-by: Kimonas Sotirchos <[email protected]> * manifests: Set the prefix in the backend The backend should also be aware of the prefix in order to configure the frontend files accordingly. Signed-off-by: Kimonas Sotirchos <[email protected]> * Update the manifests for KF release (#27) * rename web-app to base in manifests Signed-off-by: Kimonas Sotirchos <[email protected]> * rename the path of the app Signed-off-by: Kimonas Sotirchos <[email protected]>
kimwnasptd
added a commit
that referenced
this pull request
Jul 20, 2022
* manifests: Update to v0.8.0 tag Signed-off-by: Kimonas Sotirchos <[email protected]> * manifests: Update gateways and prefix (#32) * manifests: Use explicit gateways Replace the variable substitution for the web app and hardcode the Gateway that will be used in each case. Signed-off-by: Kimonas Sotirchos <[email protected]> * manifests: Set the prefix in the backend The backend should also be aware of the prefix in order to configure the frontend files accordingly. Signed-off-by: Kimonas Sotirchos <[email protected]> * Update the manifests for KF release (#27) * rename web-app to base in manifests Signed-off-by: Kimonas Sotirchos <[email protected]> * rename the path of the app Signed-off-by: Kimonas Sotirchos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to get the manifests of the web app ready for a KF installation kubeflow/manifests#2110
The PR does the following changes:
kserve-endpointsweb-apptobaseI also believe we should have a discussion around the nomenclature of the project. I think the naming
endpointsis a better fit for the app and the InferenceService objects it manages. Let's discuss this more in a concrete issue.