-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to export list of org repo #27
Conversation
bbf0fd2
to
4a0397b
Compare
4a0397b
to
7c7ab30
Compare
Travis tests have failedHey @kx-chen, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: 2f69ff10-e398-11e8-8936-1328ec1a4b2b |
353e6d4
to
3189392
Compare
026035f
to
3051e3d
Compare
Travis tests have failedHey @kx-chen, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: 208eb840-e3da-11e8-b310-57bc1b8e3114 |
Travis tests have failedHey @kx-chen, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: 3573d740-e3da-11e8-b310-57bc1b8e3114 |
3051e3d
to
583131d
Compare
583131d
to
5f0d5da
Compare
Travis tests have failedHey @kx-chen, 1st Buildcoala --non-interactive -V
TravisBuddy Request Identifier: d8bb2110-e402-11e8-b310-57bc1b8e3114 |
5a1748f
to
432cfbf
Compare
432cfbf
to
e0bfbee
Compare
e0bfbee
to
a454e05
Compare
|
||
return parser | ||
|
||
|
||
def encode_repo_list(repo_data, encoder_name, styled): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't have this method acess styled
as an argument, this would make it tough for us to move over to a standard logger when we decide to do that. A better way would be to have this method return appropriate values or raise exceptions that should be caught and processed in main()
. This method should not have these kind of side effects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred to be part of #23.
a454e05
to
5ecdd48
Compare
5ecdd48
to
44a8fc5
Compare
44a8fc5
to
33653c1
Compare
33653c1
to
d4eb5d1
Compare
Add option to export list of org repos into different formats. Closes ksdme#6
d4eb5d1
to
225b246
Compare
Add option to export list of org repos into different formats.
Closes #6