get rid of mvn and use jar-dependency to resolve //DEPS

[holgerbrandl]

E.g. https://www.eclipse.org/proposals/technology.aether/

[stephenbmfj]

Aether seems to be dead. Groovy Grape use Ivy to do it. (https://github.com/groovy/groovy-core/blob/master/src/main/groovy/grape/GrapeIvy.groovy)

[holgerbrandl]

Or we could use https://github.com/kohesive/keplin

[gildor]

Keplin uses aether under the hood.
Grape also updated last time 3 years ago, later than Aether but still not under active development.
Also, even Gradle uses Aether for maven (at least for publication, as I see, but cannot be sure).

Maybe make sense to ask an advice for someone from Gradle team. But Aether still looks like a good option and better than standalone mvn

[holgerbrandl]

Thanks for the info and the codepointer @gildor.

[gildor]

Also, would be good if Aether (or other implementation) could reuse local .m2 cache to prevent dependency downloading only for script

[gildor]

@holgerbrandl I've started working on Aether integration in my fork and now have early proof of concept that passes all the tests. I should clean up and probably refactor dependency resolution and tests.

Did you consider something about this feature? Maybe you have some different plans

If you still think that this is a good idea I can continue work to have production-ready prototype

[holgerbrandl]

That's really exciting news! We just have to integrate it carefully to avoid breaking user-installations. There are some dependency tests already, but I'm not sure if they really cover the full spectrum of use-cases yet.

Only considerations from my end

• maintain option to allow for custom artifact repos (see https://github.com/holgerbrandl/kscript#can-i-use-custom-artifact-repositories)
• maintain artifact download reporting: currently kscript captures some parts of the maven logs and forwards them to the users to indicate progress when downloading dependencies.

Never touched but still on the list are also dependency exclusions #12

How much does the shadow jar grow by adding aether?

[gildor]

@holgerbrandl

maintain option to allow for custom artifact repos

Yes, custom repos already supported

maintain artifact download reporting

I have some logs already, no progress tho, just message about artifact downloading

dependency exclusions

Shouldn't be a problem, Aether supports exclusion

How much does the shadow jar grow by adding aether

I'm not sure now, currently, I use some third party libs for fast implementation, but I plan to get rid of them and use only minimal set. But will report later

[holgerbrandl]

We don't have detailed logging at the moment. Just something like
Started downloading log4j_3.2 .... Done
and so on. See https://github.com/holgerbrandl/kscript/blob/master/src/main/kotlin/kscript/app/DependencyUtil.kt#L116

Anything more detailed is likely to be more annoying than useful. I just added it to avoid the impression that kscript is stuck, while it is resolving dependencies internally.

[andreas-mausch]

What's the status here? Can I see @gildor's the code somewhere?

[andreas-mausch]

I'm impatient and started an implementation. Tests are green, haven't checked compatibility for the dependency_cache yet tho. See PR #159

[holgerbrandl]

Duplicate of #159