Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative path of artifactbundle #1182

Conversation

erichoracek
Copy link
Collaborator

@erichoracek erichoracek commented Jul 17, 2023

The artifactbundle.info.json.template references the sourcery/bin subdirectory but the binary is not moved to that path so the artifactbundle does not work correctly. We need to actually move the file there and then we get the right structure

Artifact bundle support was originally added in #1155 by @InkyTsar

The artifactbundle.info.json.template references the `sourcery/bin` subdirectory but the binary is not moved to that path so the artifactbundle does not work correctly. We need to actually move the file there and then we get the right structure
@erichoracek
Copy link
Collaborator Author

Here's the docs on the structure of the artifact bundle if it's helpful

@krzysztofzablocki krzysztofzablocki merged commit 95dbbc0 into krzysztofzablocki:master Jul 20, 2023
@krzysztofzablocki
Copy link
Owner

thanks!

@utahwithak
Copy link

This still appears to be broken in the 2.1.1 release. I'm seeing the structure be:
bundle

  • info.json
  • sourcery
    • bin
      • sourcery
        • bin
          the info.json is specifying sourcery/bin/sourcery which is incorrect.

It should be pointing directly to the executable which would be sourcery/bin/sourcery/bin/sourcery I feel like this is a bit too nested and the whole nested sourcery folder should be brought up so it's just sourcery/bin/sourcery

@art-divin
Copy link
Collaborator

👋🏻 Thank you @utahwithak ,

I'll have a look once I have a minute 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants