Correctly handle large values earlier in limit percent

kryonix · Feb 28, 2024 · 598e092 · 598e092
1 parent e663f20
commit 598e092
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/planner/binder/query_node/bind_select_node.cpp b/src/planner/binder/query_node/bind_select_node.cpp
@@ -70,8 +70,8 @@ BoundLimitNode Binder::BindLimitValue(OrderBinder &order_binder, unique_ptr<Pars
 			} else {
 				percentage_val = val.GetValue<double>();
 			}
-			if (percentage_val < 0) {
-				throw BinderException(expr->query_location, "LIMIT cannot be negative");
+			if (Value::IsNan(percentage_val) || percentage_val < 0 || percentage_val > 100) {
+				throw OutOfRangeException("Limit percent out of range, should be between 0% and 100%");
 			}
 			return BoundLimitNode::ConstantPercentage(percentage_val);
 		} else {