test: add prove fault with zkVM tests #394
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| import { L2OutputOracle } from "contracts/L1/L2OutputOracle.sol"; | ||
| import { ZKProofVerifier } from "contracts/L1/ZKProofVerifier.sol"; | ||
|
|
||
| contract MockColosseum is Colosseum { |
There was a problem hiding this comment.
I think it would be better to move this file into mock folder or sth, since test folder itself only contains .t.sol files.
| function _getOutputRoot( | ||
| address _sender, | ||
| uint256 _blockNumber, | ||
| bool _isZkVm |
There was a problem hiding this comment.
How about removing this for each internal functions and just use isZkVm global variable?
| uint256 _segSize, | ||
| bool _isZkVm |
There was a problem hiding this comment.
Curious, don't we also have to add this to the tests at Colosseum_ValidatorSystemUpgrade_Test?
| @@ -210,6 +229,31 @@ func (rt *Runtime) assertRedeployValPoolToTerminate(newTerminationIndex *big.Int | |||
| require.Equal(rt.t, types.ReceiptStatusSuccessful, receipt.Status, "upgrade tx submission failed") | |||
| } | |||
|
|
|||
| // assertReplaceMockColosseum deploys MockColosseum which has setL1Head function and upgrades proxy for challenge test. | |||
| // It also asserts that the deploying and upgrade tx is successful. | |||
| func (rt *Runtime) assertReplaceMockColosseum() { | |||
There was a problem hiding this comment.
How about assertReplaceWithMockColosseum ?
| } | ||
|
|
||
| // ReplaceMockColosseum deploys MockColosseum which has setL1Head function and upgrades proxy for challenge test. | ||
| func ReplaceMockColosseum( |
There was a problem hiding this comment.
How about ReplaceWithMockColosseum?
Description
Added contracts, e2e tests for zkVM proving fault.
L1 block hash at the moment of challenge creation is used to prove the existence of batch data, but we cannot fix L1 block hash in e2e environment. So for e2e tests, just deploy
MockColosseumwhich has manualsetL1Headfunction and replace L1 block hash with test data using that function.Currently the prover tests are ongoing, so I'll replace the test data with real working data and enable the related tests when the prover tests finish.