feat: separate DepositTx and set suggested fee recipient #391

Pangssu · 2024-11-07T12:08:47Z

To reduce code diffs with optimism, separate DepositTx into a OP version and Kroma version, and set suggestedFeeRecipient for payload attributes

This PR should be merged after #390 is merged.

coderabbitai · 2024-11-07T12:08:54Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

dev
main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kangsorang · 2024-11-24T23:56:32Z

op-node/p2p/sync.go

+	// [Kroma: START] Use KromaDepositTx instead of DepositTx before MPT time
+	if !s.cfg.IsKromaMPT(expectedTime) {
+		for i, otx := range res.Transactions {
+			if otx[0] == types.DepositTxType {
+				var err error
+				res.Transactions[i], err = derive.ToKromaDepositBytes(otx)
+				if err != nil {
+					return nil, fmt.Errorf("failed to convert deposit tx: %w", err)
+				}
+			}
+		}
+	}
+	// [Kroma: END]
+


Since we already have ecotone applied, shouldn't we consider the case for version 1 ? I don't think there are any p2p nodes requesting version 0.

kangsorang · 2024-11-25T00:06:46Z

op-service/eth/types.go

@@ -261,6 +261,15 @@ func BlockAsPayload(bl *types.Block, canyonForkTime *uint64) (*ExecutionPayload,
 			return nil, fmt.Errorf("tx %d failed to marshal: %w", i, err)
 		}
 		opaqueTxs[i] = otx
+		// [Kroma: START] Use KromaDepositTx instead DepositTx


Suddenly I had this thought.
Couldn't we just apply IsKromaDepositTx to encodeTyped paired with the decodeTyped function and not have to put this code in?

sm-stack · 2024-11-25T02:32:08Z

op-node/rollup/derive/ecotone_upgrade_transactions.go

 		// [Kroma: START]
 		Gas: 500_000,
-		// IsSystemTransaction: false,
 		// [Kroma: END]


Can we revert this gas back to 375_000, since ecotone fork is now successfully done?

Pangssu requested a review from a team November 7, 2024 12:08

Pangssu requested a review from a team as a code owner November 7, 2024 12:08

Pangssu removed the request for review from a team November 7, 2024 12:08

Pangssu force-pushed the feat/separate-deposit-tx branch from 8285ca1 to 67258f3 Compare November 8, 2024 08:08

Pangssu requested a review from a team as a code owner November 8, 2024 08:08

seolaoh force-pushed the feat/zkvm-fault-proof branch from fa2f566 to a820693 Compare November 8, 2024 09:32

feat: handle mpt transition time

3a037f8

Pangssu force-pushed the feat/separate-deposit-tx branch from 67258f3 to 86da0e2 Compare November 9, 2024 05:22

Pangssu added 3 commits November 9, 2024 17:30

feat: separate DepositTx into OP version and Kroma version

11f2c8f

fix: resolve test failures due to different deposit tx types

7e8fc98

feat: set suggested fee recipient for payload attributes

3473ad1

Pangssu force-pushed the feat/separate-deposit-tx branch from 86da0e2 to 3473ad1 Compare November 9, 2024 08:30

kangsorang reviewed Nov 24, 2024

View reviewed changes

kangsorang reviewed Nov 25, 2024

View reviewed changes

sm-stack reviewed Nov 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: separate DepositTx and set suggested fee recipient #391

feat: separate DepositTx and set suggested fee recipient #391

Pangssu commented Nov 7, 2024 •

edited

Loading

coderabbitai bot commented Nov 7, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

kangsorang Nov 24, 2024

kangsorang Nov 25, 2024

sm-stack Nov 25, 2024

feat: separate DepositTx and set suggested fee recipient #391

Are you sure you want to change the base?

feat: separate DepositTx and set suggested fee recipient #391

Conversation

Pangssu commented Nov 7, 2024 • edited Loading

coderabbitai bot commented Nov 7, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

kangsorang Nov 24, 2024

Choose a reason for hiding this comment

kangsorang Nov 25, 2024

Choose a reason for hiding this comment

sm-stack Nov 25, 2024

Choose a reason for hiding this comment

Pangssu commented Nov 7, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)