Dev -> Main #175
Merged
Dev -> Main #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The submission round is split into public round and priority round, and previously at most one bond is unbonded when submitting each output. Therefore, bonds to be unbonded could be pending when output submission have beed delayed. So changed to unbond multiple bonds up to `MAX_UNBOND` in each output submission, and select next priority validator using the last unbonded output.
- Added `defaultRuntime` function. - Moved challenger balance check into `setupChallenge`. - Removed challenger bisection timeout test case cause we cannot test it in current test setup. Cause we set `ColosseumSegmentsLengths` to "3,4" in setup, challenger does not have bisect turn.
feat(contracts): unbond multiple bonds
…eout test(e2e): add challenger timeout fail test
docs: update specs - differences from Optimism
…torage-root docs(validator): validate withdrawal storage root against state root
Added metric 1. The deposit amount into the ValidatorPool contract. 2. The address of the next validator. 3. The output index that the challenge function last checked.
feat(validator): add validator metrics
Added expected behavior.
chore: revise issue template
feat!(validator): rename output submitter and challenger flags
…o-guide docs(validator): add `ValidatorPool` address to validator deposit guide
Executes the transaction requests sequentially and returns receipt as response.
- Using buffered txmgr in validator. - Add retry logic in output submitter. - Add retry logic in challenger. - Add retry logic in output guardian.
perf(validator): handle errors of validator's transactions
- Add challenge timeout fail case for asserter, challenger.
test(e2e): add challenge timeout fail case
We don't need to progress challenge process further when related output has already finalized. Therefore, revert challenge process of finalized output.
Prevent challenger and guardian sending unnecessary transactions which are related to challenge of finalized output.
…put-challenge feat: prevent progressing challenge of finalized output
ci: run test ci on main
# Conflicts: # components/validator/guardian.go # components/validator/l2_output_submitter.go
chore: apply hotfix v0.2.2
Change kroma portal guardian to securityCouncil(multisig wallet).
fix(chain-ops): change portal guardian to multisig wallet
…ratio-metrics feat(batcher): add ChannelComprRatioValue metrics
fix(validator): skip request deletion when output already been deleted
Challenger continuously restarts when kroma node is syncing. To prevent it, changes to loop when error occurred, not restart. And check sync status in validator initially, because currently all the components in validator commonly check it. We do not log sync status error while syncing because node always does not respond while syncing.
Since validator is made up of multiple components and can be turned on at the same time, adds component names to the logs so that you can distinguish the logs by component. However, some of the logic in the challenger component works even when only the submitter is enabled, so in that case use `challenge` for the name.
chore: renaming configuration values in governor
Added protocol for using custom time-lock zero delay for urgent situations.
feat(contract): add zero timelock for urgent situation
Permissions to add, remove members, and modify requirements were granted to the governor contract instead of the multisig wallet itself. This allows for unified policy enforcement through the governor.
…uritycouncil feat(contract): change permissions for securityCouncil
The ZKVerifier contract is set up via deploy config as part of the contract code is different for each chain id.
…tart-while-sync fix(validator): prevent challenger restart while sync
feat(contracts): improvement ZKVerifier contract
chore: bump kroma-geth from 0.2.0 to 0.2.1
chore: update sepolia config v0.3.0
Pangssu
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
devintomain