[CHORE] swap flt-seo tag with div (#72)

* [CHORE] swap flt-seo tag with div * no message
krokyze · Mar 31, 2024 · afaf6b0 · afaf6b0
1 parent 7715382
commit afaf6b0
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/.fvm/fvm_config.json b/.fvm/fvm_config.json
diff --git a/.fvmrc b/.fvmrc
@@ -0,0 +1,4 @@
+{
+  "flutter": "3.19.4",
+  "flavors": {}
+}
diff --git a/.gitignore b/.gitignore
@@ -38,5 +38,5 @@ unlinked.ds
 unlinked_spec.ds
 app.*.symbols
 
-# FVM
-.fvm/flutter_sdk
+# FVM Version Cache
+.fvm/
diff --git a/lib/html/seo_controller.dart b/lib/html/seo_controller.dart
@@ -64,7 +64,7 @@ class _SeoControllerState extends State<SeoController> {
 
   final _bodyValidator = NodeValidatorBuilder()
     ..allowHtml5(uriPolicy: _AllowAllUriPolicy())
-    ..allowCustomElement('flt-seo')
+    ..allowCustomElement('div', attributes: ['flt-seo'])
     ..allowCustomElement('noscript')
     ..allowCustomElement('h1', attributes: ['style'])
     ..allowCustomElement('h2', attributes: ['style'])
@@ -147,11 +147,12 @@ class _SeoControllerState extends State<SeoController> {
     if (_bodyHash == hash) return;
     _bodyHash = hash;
 
-    body.children.removeWhere((element) => element.localName == 'flt-seo');
+    body.children
+        .removeWhere((element) => element.attributes.containsKey('flt-seo'));
 
     body.insertAdjacentHtml(
       'afterBegin',
-      '<flt-seo>${html.body}</flt-seo>',
+      '<div flt-seo>${html.body}</div>',
       validator: _bodyValidator,
     );
   }

diff --git a/test/base.dart b/test/base.dart
@@ -14,7 +14,7 @@ String? get headHtml => document.head?.children
     .join('\n');
 
 String? get bodyHtml => document.body?.children
-    .firstWhereOrNull((element) => element.localName == 'flt-seo')
+    .firstWhereOrNull((element) => element.attributes.containsKey('flt-seo'))
     ?.innerHtml;
 
 Duration measure<T>(T Function() measure) {