Skip to content

Commit

Permalink
Insteon: Prevent Calling Success Callback if No Active Message
Browse files Browse the repository at this point in the history
  • Loading branch information
krkeegan committed Nov 23, 2013
1 parent b1f8f5d commit 1bae8a8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/Insteon/BaseInsteon.pm
Original file line number Diff line number Diff line change
Expand Up @@ -1966,7 +1966,8 @@ sub _get_engine_version_failure
$self->engine_version('I2CS');
}
#Clear success callback, otherwise it will run when message is cleared
$self->interface->active_message->success_callback('0');
$self->interface->active_message->success_callback('0')
if (ref $self->interface->active_message);
}

=item C<ping([count])>
Expand Down

1 comment on commit 1bae8a8

@pmatis
Copy link

@pmatis pmatis commented on 1bae8a8 Nov 23, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did this. LOL - except I use defined, instead of ref.
There's also one more spot in Insteon_PLM.

Compare to my issue hollie#323 commit.

Please sign in to comment.