Skip to content

Commit

Permalink
[contrib] Stop building ICU tools to fix gcc Envoy build
Browse files Browse the repository at this point in the history
Clang and gcc are subtly different and it seems to be the cause
of contrib build failures reported in
envoyproxy#31807 (e.g., when using
gcc to link the final binary it results in a bunch of essential
for gcc C++ symbols like __gxx_personality_v0).

This issue could be addressed (i.e., Envoy can be built using gcc).
However, given that it only happens when we build ICU binary tools
and those tools aren't used by Envoy directly or the build system,
we can just not build them and address the issue this way.

Signed-off-by: Mikhail Krinkin <[email protected]>
  • Loading branch information
krinkinmu committed Nov 7, 2024
1 parent 1922c84 commit 01a4bcc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion bazel/foreign_cc/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ configure_make(
configure_options = [
"--enable-option-checking",
"--enable-static",
"--enable-tools",
"--disable-draft",
"--disable-dyload",
"--disable-extras",
Expand All @@ -193,6 +192,7 @@ configure_make(
"--disable-samples",
"--disable-shared",
"--disable-tests",
"--disable-tools",
"--with-data-packaging=static",
],
data = ["@com_github_unicode_org_icu//:all"],
Expand Down

0 comments on commit 01a4bcc

Please sign in to comment.