Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRACKING: feature/redux → feature/apollo #1147

Closed
wants to merge 51 commits into from
Closed

TRACKING: feature/redux → feature/apollo #1147

wants to merge 51 commits into from

Conversation

langpavel
Copy link
Collaborator

@langpavel langpavel commented Feb 24, 2017 •
edited
Loading

  • Apollo client mounted on existing redux store
  • Data are automatically prefetched on server, no imperative code in router
  • Direct server side GraphQL - no additional HTTP request on SSR
  • GraphQL queries are pre-parsed by Webpack loader
  • Demonstrated on Home route/component

@langpavel langpavel mentioned this pull request Feb 24, 2017
Closed
@langpavel langpavel changed the title TRACKING: Apollo Client Integration TRACKING: feature/redux → feature/apollo Feb 24, 2017
@langpavel langpavel self-assigned this Mar 13, 2017
@stubailo
Copy link

Just looked over everything, this looks awesome - is there anything in particular you would want more feedback on?

@langpavel
Copy link
Collaborator Author

@stubailo Feedback is welcomed, but this is feature branch.
It should be for reference. When I came to RSK I feel it should cover more advanced topics. It still appears around. I'm happy with this but I feel more people wants more.. On other side, I want people knowing why this..

@stubailo
Copy link

Ah, OK - so the idea is to keep it open as an example for how to do a certain thing, but not merge it?

I'd be happy to help provide some content about what this is doing, or help add some more advanced features.

@langpavel
Copy link
Collaborator Author

langpavel commented Mar 21, 2017 •
edited
Loading

I'm using this in production on two small sites, I'm back-pushing features there.. I love learning and feedback
but RSK is not my property, so I have clean deal with @koistya, this will be "feature". I will be happy with redux to be merged in, but this is still too much for starter. Koistya have it's own PR as simplest advice to opt in redux. I can fork RSK and maintain fork myself, but it will not be so beneficial because there are too much work done..

About Apollo, this is so opinionated, I'm almost sure this will never lands, but I will keep it up to date I promise

So enjoy my work, if you want my response, just mention me @stubailo :-)

@langpavel langpavel mentioned this pull request Mar 23, 2017
Closed
@tim-soft
Copy link

tim-soft commented May 5, 2017 •
edited
Loading

First of all, this is an awesome boilerplate

Poking around in the code has brought up a few questions

  1. Why go with graphql/express-graphql over apollographql/graphql-server, which seems to pair really nicely with the Apollo Client?

Which brings up my next question

  1. Apollo client supports subscriptions, shouldn't the apollo client feature branch be exemplary of this feature? (I may be mistaken, but I do not believe it is in here)

Thank you for your hard work @langpavel!

@tim-soft
Copy link

@leviwheatcroft Where things get a little more complex/opinionated with subscriptions is a pub/sub system. Something like Redis is a very big dependency and the Websocket server should be it's own app imo

tim-soft and others added 19 commits January 5, 2018 14:31
@tim-soft @langpavel
[feature/Apollo] Upgrade to Apollo Client 2.0 (#1492)
a65988a 
* ⬆️ Upgrade to Apollo Client 2.0
* Tweak HttpLink Credentials
* Fix Layout test
@langpavel
Merge branch 'feature/redux' into feature/apollo
4ce25fc
@langpavel
Downgrade graphql (0.12.3 -> 0.11.7)
bcb056b
@langpavel
fix Apollo state (re)hydration
eeac362
@langpavel
Merge branch 'feature/redux' into feature/apollo
8effc49
@tim-soft @langpavel
✨ Log Apollo ops in development (#1496)
c956344
@langpavel
Merge branch 'feature-apollo-single-source-of-graphql-query' of git:/…
712b80a 
…/github.com/KrzysztofKarol/react-starter-kit
@langpavel
Use apollo client in router instead of fetch
ea5111e
@langpavel
Merge branch 'KrzysztofKarol-feature-apollo-single-source-of-graphql-…
c8f7165 
…query' into feature/apollo
@langpavel
Merge branch 'feature/redux' into feature/apollo
8764b24
@tim-soft @langpavel
♻️ Implement GraphQL-Tools based Schema (#1498)
9382aa2
@langpavel
Merge branch 'feature/redux' into feature/apollo
d7d4187
@langpavel
Fix errors in graphql-tools implementation (#1503)
7373ec4
@langpavel
Merge branch 'feature/redux' into feature/apollo
4fb56bc
@langpavel
Merge branch 'feature/redux' into feature/apollo
80cac88
@langpavel
Merge branch 'feature/redux' into feature/apollo
3042323
@langpavel
chore: yarn upgrade --latest
d4c8bf6
@langpavel
fix(redux): createRootReducer → rootReducer
6c851d3
@langpavel
Merge branch 'feature/redux' into feature/apollo
d5cf707
@piglovesyou
Copy link
Collaborator

piglovesyou commented Jul 5, 2018 •
edited
Loading

@langpavel This is the best combination of the web frontend of the time I feel, I was inspired from this branch a lot. Thanks.

Thing is, Apollo Client does not have to depend on Redux since it has its own caching mechanism. The official docs points to this blog post.

So what do you think when I say feature/apollo can only based on master, instead of feature/redux? That will push efficiency and simplicity of the boilerplate forward, I believe.

But yeah feature/react-intl is a dependant of feature/apollo and things are a little complicated. Then I think I also can push a new feature/apollo-pure or something.

@tim-soft
Copy link

tim-soft commented Jul 5, 2018

@piglovesyou I'm not sure what you mean... Apollo client isn't relying on Redux at all.
a65988a

@piglovesyou
Copy link
Collaborator

piglovesyou commented Jul 5, 2018 •
edited
Loading

@tim-soft Yeah I know Apollo Client doesn't. Then how about having "Redux-free Apollo branch" in RSK?

AS IS: feature/apollo based on feature/redux
My proposal: feature/apollo based on master

@jatinnn
Copy link

jatinnn commented Jul 12, 2018

Would have been nice if feature/apollo was based on master rather then feature/redux.

@langpavel
Copy link
Collaborator Author

@piglovesyou feature/apollo-pure sounds great. But I'm sorry, I have no time to do this in near future

@piglovesyou
Copy link
Collaborator

@langpavel Good to hear that.

I'm really interested in doing it using apollo-link-state and apollo-server, but I cannot promise starting it soon（´-｀;）

@piglovesyou
Copy link
Collaborator

#1664

I created a PR of a pure Apollo branch called feature/apollo-pure. Basically I just introduced

  • apollo-link-state
    • with initial state sharing between server and client
    • with networkState example
  • apollo-server

without

  • redux
  • Fetch function in a context, since apollo-client will take care of it

upon the master branch, by picking some codebase from feature/apollo. I really appreciate a quick review from the Apollo-interested engineers around.

@langpavel
Copy link
Collaborator Author

@piglovesyou, nice nickname 🤣
Great work! Thank you! Let's discuss more in #1664

@montoya332
Copy link

should these be closed since they are outdated

@koistya koistya closed this Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@langpavel langpavel

Labels
branch feature/apollo branch feature/redux TRACKING
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.