Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added collapsible directive #13

Merged
merged 2 commits into from
Apr 22, 2015
Merged

Added collapsible directive #13

merged 2 commits into from
Apr 22, 2015

Conversation

elboman
Copy link
Contributor

@elboman elboman commented Apr 19, 2015

I've added a collapsible directive to make it work out-of-the-box with the data-attribute from materialize thanks to the fact that angular also watches for data-attributes directives. Probably it should be added to the documentation to make it more clear.

elboman added 2 commits April 20, 2015 01:29
scope.$watch was watching for undefined value to trigger blur, but that caused a bug for empty strings
@sibinx7
Copy link

sibinx7 commented Apr 20, 2015

Sir

Can you add some examples, I copied your commit and added in project.. It shows some error, it may be my mistake. Can you add some working examples?

@elboman
Copy link
Contributor Author

elboman commented Apr 21, 2015

Can you include your error here? it works fine for me.. what version of angular are you using?

@sibinx7
Copy link

sibinx7 commented Apr 21, 2015

Latest angular and latest materialize . If you don't mind please add some
working examples...

On Tue 21 Apr, 2015 6:17 am Marco Botto [email protected] wrote:

Can you include your error here? it works fine for me.. what version of
angular are you using?


Reply to this email directly or view it on GitHub
#13 (comment)
.

@elboman
Copy link
Contributor Author

elboman commented Apr 22, 2015

Here is a plunkr (http://plnkr.co/edit/LgEo8tT1EK2Z79b9UErO) with the collapsible working added from angular and compiled to show the directive working. I must point out that the current simple integration only works for static collapsible because thats what I needed, I can improve it to work with ng-repeat inside or some model to iterate on..

@elboman
Copy link
Contributor Author

elboman commented Apr 22, 2015

Now that I think about it, since it's wrapper inside $timeout, any ng-repeat inside is compiled before, so it should work.. I created another plunkr to show you: http://plnkr.co/edit/qDWsklDrQ34sckXA6OrM

Hope it helps!

@sibinx7
Copy link

sibinx7 commented Apr 22, 2015

Thanks... It working

@webbiesdk webbiesdk merged commit a5b1138 into krescruz:master Apr 22, 2015
webbiesdk pushed a commit that referenced this pull request Apr 22, 2015
@webbiesdk
Copy link
Collaborator

Nice work (simple, but sometimes simple is good).

I used your last plunkr as the example in the index.html file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants