Improve content type detector #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve content type detector by getting all types back from Marcel and cross-referencing them with the possible types (file extension). This is an improvement because we don't want to trust Marcel to order their magic detection appropriately.
sbhawsingka
approved these changes
Jan 8, 2022
|
Hi @ngan @sbhawsingka what do you think of #75 |
|
Closing in favor of #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve content type detector by getting all types back from Marcel and cross-referencing them with the possible types (file extension). This is an improvement because we don't want to trust Marcel to order their magic detection appropriately.
For example, I have a PDF that contains the string
wmv2and Marcel is reporting that it's avideo/x-ms-wmvfile: https://github.com/rails/marcel/blob/main/lib/marcel/tables.rb#L2164. This is obviously wrong. If we were to useMarcel::Magic.all_by_magicthenapplication/pdfis among the list of types returned. If Marcel considers it to be a possible PDF and the extension declares it as a pdf, let's just go with that.