Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

first modularization #21

Merged
merged 5 commits into from
Oct 1, 2018
Merged

first modularization #21

merged 5 commits into from
Oct 1, 2018

Conversation

pkra
Copy link
Member

@pkra pkra commented Sep 29, 2018

Resolves #17

@pkra pkra requested a review from zorkow September 29, 2018 21:36
@pkra
Copy link
Member Author

pkra commented Sep 29, 2018

@zorkow what do you think?

@pkra
Copy link
Member Author

pkra commented Sep 29, 2018

@zorkow if you're ok with this, I'll add the remaining changes (remove chromfiy.js and update ser-enrich and the sample to load main.mjs)

zorkow
zorkow approved these changes Oct 1, 2018
View reviewed changes
Copy link
Collaborator

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you give files mjs extensions?

@pkra
Copy link
Member Author

pkra commented Oct 1, 2018

Why do you give files mjs extensions?

.mjs is necessary for NodeJS, cf. https://nodejs.org/api/esm.html#esm_enabling

@pkra pkra merged commit f716cc6 into master Oct 1, 2018
@pkra pkra deleted the firstmodularization branch October 1, 2018 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zorkow zorkow zorkow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkra @zorkow