Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update svelte to 1.58.5 #369

Merged
merged 2 commits into from
Mar 30, 2018
Merged

Conversation

Rich-Harris
Copy link
Contributor

This fixes the recent performance regression (#367) with a new list diffing algorithm. Should be much quicker now! Thanks

@Rich-Harris Rich-Harris changed the title update svelte to 1.58.2 update svelte to 1.58.5 Mar 30, 2018
@krausest krausest merged commit 644c5a8 into krausest:master Mar 30, 2018
@krausest
Copy link
Owner

That looks much better!
bildschirmfoto 2018-03-30 um 18 55 22
The red benchmarks are significantly slower than 1.42. Is that expected (might also be due to Chrome and OS updates)?
bildschirmfoto 2018-03-30 um 18 57 09

@krausest
Copy link
Owner

Complete results are available here.

@Rich-Harris
Copy link
Contributor Author

Nice, thanks! Yes, our row creation needs to get faster. Not sure off the top of my head what explains the regression, but getting that down is very much on our TODO list.

In the meantime, I'll report this back to our chatroom so we can luxuriate in our number one spot for TTI, bootup time, memory usage etc 😀

@Rich-Harris Rich-Harris deleted the svelte-v1.58.2 branch March 30, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants